netdev - RE: [PATCH bpf-next 0/3] fixes for bpftool's Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <616d7f32e2125_1eb12088b@john-XPS-13-9370.notmuch>
Date:   Mon, 18 Oct 2021 07:05:38 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Quentin Monnet <quentin@...valent.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org,
        Quentin Monnet <quentin@...valent.com>
Subject: RE: [PATCH bpf-next 0/3] fixes for bpftool's Makefile

Quentin Monnet wrote:
> This set contains one fix for bpftool's Makefile, to make sure that the
> headers internal to libbpf are installed properly even if we add more
> headers to the relevant Makefile variable in the future (although we'd like
> to avoid that if possible).
> 
> The other patches aim at cleaning up the output from the Makefile, in
> particular when running the command "make" another time after bpftool is
> built.
> 
> Quentin Monnet (3):
>   bpftool: fix install for libbpf's internal header(s)
>   bpftool: do not FORCE-build libbpf
>   bpftool: turn check on zlib from a phony target into a conditional
>     error
> 
>  tools/bpf/bpftool/Makefile | 29 +++++++++++++++--------------
>  1 file changed, 15 insertions(+), 14 deletions(-)
> 
> -- 
> 2.30.2
> 

I'm not a Makefile expert, but from my side these look good. Thanks.

Acked-by: John Fastabend <john.fastabend@...il.com>