netdev - Re: [PATCH net-next 02/12] ethernet: sky2/skge: use eth_hw_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211018100148.75ab3f23@hermes.local>
Date:   Mon, 18 Oct 2021 10:01:48 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, mlindner@...vell.com
Subject: Re: [PATCH net-next 02/12] ethernet: sky2/skge: use
 eth_hw_addr_set()

On Mon, 18 Oct 2021 07:29:22 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> of VLANs...") introduced a rbtree for faster Ethernet address look
> up. To maintain netdev->dev_addr in this tree we need to make all
> the writes to it got through appropriate helpers.
> 
> Read the address into an array on the stack, then call
> eth_hw_addr_set().
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: mlindner@...vell.com
> CC: stephen@...workplumber.org

Looks ok. Don't even use any of that hardware anymore.

Acked-by: Stephen Hemminger <stephen@...workplumber.org>