netdev - RE: [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4b733db61544d7a9fd0134cfe02fb44@realtek.com>
Date:   Mon, 18 Oct 2021 03:39:03 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>
Subject: RE: [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()


> -----Original Message-----
> From: Yang Yingliang <yangyingliang@...wei.com>
> Sent: Monday, October 18, 2021 11:31 AM
> To: linux-kernel@...r.kernel.org; netdev@...r.kernel.org; linux-wireless@...r.kernel.org
> Cc: Pkshih <pkshih@...ltek.com>; kuba@...nel.org; davem@...emloft.net; kvalo@...eaurora.org
> Subject: [PATCH net-next] rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
> 
> Fix the return value check which testing the wrong variable
> in rtw89_cam_send_sec_key_cmd().
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/cam.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/cam.c
> b/drivers/net/wireless/realtek/rtw89/cam.c
> index c1e8c76c6aca..ad7a8155dbed 100644
> --- a/drivers/net/wireless/realtek/rtw89/cam.c
> +++ b/drivers/net/wireless/realtek/rtw89/cam.c
> @@ -77,7 +77,7 @@ static int rtw89_cam_send_sec_key_cmd(struct rtw89_dev *rtwdev,
>  		return 0;
> 
>  	ext_skb = rtw89_cam_get_sec_key_cmd(rtwdev, sec_cam, true);
> -	if (!skb) {
> +	if (!ext_skb) {
>  		rtw89_err(rtwdev, "failed to get ext sec key command\n");
>  		return -ENOMEM;
>  	}
> --
> 2.25.1
> 
> ------Please consider the environment before printing this e-mail.