netdev - Re: [PATCH net-next 10/11] fddi: use eth_hw_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2110180427110.31442@angie.orcam.me.uk>
Date:   Mon, 18 Oct 2021 04:34:28 +0200 (CEST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Jakub Kicinski <kuba@...nel.org>
cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 10/11] fddi: use eth_hw_addr_set()

On Fri, 1 Oct 2021, Jakub Kicinski wrote:

> diff --git a/drivers/net/fddi/skfp/skfddi.c b/drivers/net/fddi/skfp/skfddi.c
> index cc5126ea7ef5..652cb174302e 100644
> --- a/drivers/net/fddi/skfp/skfddi.c
> +++ b/drivers/net/fddi/skfp/skfddi.c
> @@ -433,7 +434,7 @@ static  int skfp_driver_init(struct net_device *dev)
>  	}
>  	read_address(smc, NULL);
>  	pr_debug("HW-Addr: %pMF\n", smc->hw.fddi_canon_addr.a);
> -	memcpy(dev->dev_addr, smc->hw.fddi_canon_addr.a, ETH_ALEN);
> +	eth_hw_addr_set(dev, smc->hw.fddi_canon_addr.a);

 Hmm, it looks to me like this ought to be abstracted somehow even if it 
ultimately expanded to exactly the same code; note that FDDI_K_ALEN should 
have been used in original code.  Not functionally incorrect however, so I 
guess no need to rush cleaning up.

  Maciej