netdev - Re: [PATCH] sfc: Export fibre-specific link modes for 1/10G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211019155306.ibxzmsixwb5rd6wx@gmail.com>
Date:   Tue, 19 Oct 2021 16:53:06 +0100
From:   Martin Habets <habetsm.xilinx@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, Erik Ekman <erik@...o.se>
Cc:     Edward Cree <ecree.xilinx@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] sfc: Export fibre-specific link modes for 1/10G

On Tue, Oct 19, 2021 at 05:31:52PM +0200, Andrew Lunn wrote:
> On Mon, Oct 18, 2021 at 08:37:08PM +0200, Erik Ekman wrote:
> > These modes were added to ethtool.h in 5711a98221443 ("net: ethtool: add support
> > for 1000BaseX and missing 10G link modes") back in 2016.
> > 
> > Only setting CR mode for 10G, similar to how 25/40/50/100G modes are set up.
> > 
> > Tested using SFN5122F-R7 (with 2 SFP+ ports) and a 1000BASE-BX10 SFP module.
> 
> Did you test with a Copper SFP modules? 
> 
> > +++ b/drivers/net/ethernet/sfc/mcdi_port_common.c
> > @@ -133,9 +133,9 @@ void mcdi_to_ethtool_linkset(u32 media, u32 cap, unsigned long *linkset)
> >  	case MC_CMD_MEDIA_QSFP_PLUS:
> >  		SET_BIT(FIBRE);
> >  		if (cap & (1 << MC_CMD_PHY_CAP_1000FDX_LBN))
> > -			SET_BIT(1000baseT_Full);
> > +			SET_BIT(1000baseX_Full);
> 
> I'm wondering if you should have both? The MAC is doing 1000BaseX. But
> it could then be connected to a copper PHY which then does
> 1000baseT_Full? At 1G, it is however more likely to be using SGMII,
> not 1000BaseX.

Yes, they should both be set. We actually did a 10Gbase-T version of Siena,
the SFN51x1T.

Martin