netdev - Re: [PATCH 3/3] dt-bindings: net: ti,bluetooth: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70d3efb8-e379-5d20-1873-4752e893f10b@lechnology.com>
Date:   Tue, 19 Oct 2021 10:41:03 -0500
From:   David Lechner <david@...hnology.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Rob Herring <robh+dt@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Russell King <linux@...linux.org.uk>,
        Sebastian Reichel <sre@...nel.org>
Cc:     devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: net: ti,bluetooth: Convert to
 json-schema

On 10/19/21 7:43 AM, Geert Uytterhoeven wrote:
> Convert the Texas Instruments serial-attached bluetooth Device Tree
> binding documentation to json-schema.
> 
> Add missing max-speed property.
> Update the example.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> I listed David as maintainer, as he wrote the original bindings.
> Please scream if not appropriate.

I'm not affiliated with TI in any way, so if someone from TI
wants to take responsibility, that would probably be better.

For for the time being...

Acked-by: David Lechner <david@...hnology.com>


> ---
>   .../devicetree/bindings/net/ti,bluetooth.yaml | 91 +++++++++++++++++++
>   .../devicetree/bindings/net/ti-bluetooth.txt  | 60 ------------
>   2 files changed, 91 insertions(+), 60 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/net/ti,bluetooth.yaml
>   delete mode 100644 Documentation/devicetree/bindings/net/ti-bluetooth.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,bluetooth.yaml b/Documentation/devicetree/bindings/net/ti,bluetooth.yaml
> new file mode 100644
> index 0000000000000000..9f6102977c9732d2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/ti,bluetooth.yaml
> @@ -0,0 +1,91 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/ti,bluetooth.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Bluetooth Chips
> +
> +maintainers:
> +  - David Lechner <david@...hnology.com>
> +
> +description: |
> +  This documents the binding structure and common properties for serial
> +  attached TI Bluetooth devices. The following chips are included in this
> +  binding:
> +
> +  * TI CC256x Bluetooth devices
> +  * TI WiLink 7/8 (wl12xx/wl18xx) Shared Transport BT/FM/GPS devices
> +
> +  TI WiLink devices have a UART interface for providing Bluetooth, FM radio,
> +  and GPS over what's called "shared transport". The shared transport is
> +  standard BT HCI protocol with additional channels for the other functions.
> +
> +  TI WiLink devices also have a separate WiFi interface as described in
> +  wireless/ti,wlcore.yaml.
> +
> +  This bindings follows the UART slave device binding in ../serial/serial.yaml.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,cc2560
> +      - ti,wl1271-st
> +      - ti,wl1273-st
> +      - ti,wl1281-st
> +      - ti,wl1283-st
> +      - ti,wl1285-st
> +      - ti,wl1801-st
> +      - ti,wl1805-st
> +      - ti,wl1807-st
> +      - ti,wl1831-st
> +      - ti,wl1835-st
> +      - ti,wl1837-st
> +
> +  enable-gpios:
> +    maxItems: 1
> +
> +  vio-supply:
> +    description: Vio input supply (1.8V)
> +
> +  vbat-supply:
> +    description: Vbat input supply (2.9-4.8V)
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: ext_clock
> +
> +  max-speed: true

Does this mean that max-speed from serial.yaml is supported
but current-speed is not?

> +
> +  nvmem-cells:
> +    maxItems: 1
> +    description:
> +      Nvmem data cell that contains a 6 byte BD address with the most
> +      significant byte first (big-endian).
> +
> +  nvmem-cell-names:
> +    items:
> +      - const: bd-address
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +