netdev - Re: [PATCH net-next] fq_codel: generalise ce_threshold marking for subset of traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Oct 2021 10:25:08 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] fq_codel: generalise ce_threshold marking for
 subset of traffic

On Tue, Oct 19, 2021 at 10:17 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> The commit in the Fixes tag expanded the ce_threshold feature of FQ-CoDel
> so it can be applied to a subset of the traffic, using the ECT(1) bit of
> the ECN field as the classifier. However, hard-coding ECT(1) as the only
> classifier for this feature seems limiting, so let's expand it to be more
> general.
>
> To this end, change the parameter from a ce_threshold_ect1 boolean, to a
> one-byte selector/mask pair (ce_threshold_{selector,mask}) which is applied
> to the whole diffserv/ECN field in the IP header. This makes it possible to
> classify packets by any value in either the ECN field or the diffserv
> field. In particular, setting a selector of INET_ECN_ECT_1 and a mask of
> INET_ECN_MASK corresponds to the functionality before this patch, and a
> mask of ~INET_ECN_MASK allows using the selector as a straight-forward
> match against a diffserv code point.

Please include what command line should be used once we get iproute2 support.

Thanks !

>
> Regardless of the selector chosen, the normal rules for ECN-marking of
> packets still apply, i.e., the flow must still declare itself ECN-capable
> by setting one of the bits in the ECN field to get marked at all.
>
> Fixes: e72aeb9ee0e3 ("fq_codel: implement L4S style ce_threshold_ect1 marking")
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> ---