netdev - Re: [PATCH] sfc: Export fibre-specific link modes for 1/10G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGgu=sA1B5=HzMYBD0r6M0BD+8fWCTOwxfEE9gTAySHABoON2Q@mail.gmail.com>
Date:   Tue, 19 Oct 2021 19:51:16 +0200
From:   Erik Ekman <erik@...o.se>
To:     Andrew Lunn <andrew@...n.ch>, Erik Ekman <erik@...o.se>,
        Edward Cree <ecree.xilinx@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] sfc: Export fibre-specific link modes for 1/10G

On Tue, 19 Oct 2021 at 19:34, Erik Ekman <erik@...o.se> wrote:
>
> On Tue, 19 Oct 2021 at 17:53, Martin Habets <habetsm.xilinx@...il.com> wrote:
> >
> > On Tue, Oct 19, 2021 at 05:31:52PM +0200, Andrew Lunn wrote:
> > > On Mon, Oct 18, 2021 at 08:37:08PM +0200, Erik Ekman wrote:
> > > > These modes were added to ethtool.h in 5711a98221443 ("net: ethtool: add support
> > > > for 1000BaseX and missing 10G link modes") back in 2016.
> > > >
> > > > Only setting CR mode for 10G, similar to how 25/40/50/100G modes are set up.
> > > >
> > > > Tested using SFN5122F-R7 (with 2 SFP+ ports) and a 1000BASE-BX10 SFP module.
> > >
> > > Did you test with a Copper SFP modules?
> > >
>
> I have tested it with a copper SFP PHY at 1G and that works fine.
> I don't have the hardware to test copper 10G (RJ45).
>
> > > > +++ b/drivers/net/ethernet/sfc/mcdi_port_common.c
> > > > @@ -133,9 +133,9 @@ void mcdi_to_ethtool_linkset(u32 media, u32 cap, unsigned long *linkset)
> > > >     case MC_CMD_MEDIA_QSFP_PLUS:
> > > >             SET_BIT(FIBRE);
> > > >             if (cap & (1 << MC_CMD_PHY_CAP_1000FDX_LBN))
> > > > -                   SET_BIT(1000baseT_Full);
> > > > +                   SET_BIT(1000baseX_Full);
> > >
> > > I'm wondering if you should have both? The MAC is doing 1000BaseX. But
> > > it could then be connected to a copper PHY which then does
> > > 1000baseT_Full? At 1G, it is however more likely to be using SGMII,
> > > not 1000BaseX.

If you mean that the card has only copper phys on the card, then a
different case in the switch statement is run
(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/sfc/mcdi_port_common.c#n149).
Should we still return both if the only baseT support is via an SFP module?

>
> Yes, we can return both.
>
> Similarly, is there a reason only CR modes are set for fiber ports,
> when I expect LR/SR/etc to work as well?
> I can set the modes for 10G similar to the example in 5711a98221443
> ("net: ethtool: add support
> for 1000BaseX and missing 10G link modes"): CR/SR/LR/ER
> I inserted a LR SFP+ module and ethtool -m could list its settings at least.
>
> >
> > Yes, they should both be set. We actually did a 10Gbase-T version of Siena,
> > the SFN51x1T.
> >
>
> For the baseT-version of the cards the supported modes are set further
> down in the file
> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/sfc/mcdi_port_common.c#n149),
> so they are not affected by this change.
>
> Thanks
> /Erik