netdev - RE: [PATCH] rtw89: fix error function parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90ac6c3911ef4f7385df3dde3d3b6d55@realtek.com>
Date:   Tue, 19 Oct 2021 05:21:21 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     "cgel.zte@...il.com" <cgel.zte@...il.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "lv.ruyi@....com.cn" <lv.ruyi@....com.cn>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Zeal Robot <zealci@....com.cn>
Subject: RE: [PATCH] rtw89: fix error function parameter


> -----Original Message-----
> From: cgel.zte@...il.com <cgel.zte@...il.com>
> Sent: Tuesday, October 19, 2021 11:53 AM
> To: kvalo@...eaurora.org
> Cc: davem@...emloft.net; kuba@...nel.org; Pkshih <pkshih@...ltek.com>; lv.ruyi@....com.cn;
> linux-wireless@...r.kernel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Zeal
> Robot <zealci@....com.cn>
> Subject: [PATCH] rtw89: fix error function parameter
> 
> From: Lv Ruyi <lv.ruyi@....com.cn>
> 
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING  possible condition with no effect (if == else)
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>

Thanks for the catch.

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> index b1b87f0aadbb..5c6ffca3a324 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> @@ -753,11 +753,11 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
>                 if (is_2g)
>                         rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
>                                               B_P1_MODE_SEL,
>                                               1, phy_idx);
>  		else
>  			rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
>  					      B_P1_MODE_SEL,
> -					      1, phy_idx);
> +					      0, phy_idx);
>  		/* SCO compensate FC setting */
>  		sco_comp = rtw8852a_sco_mapping(central_ch);
>  		rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
> --
> 2.25.1