netdev - Re: [PATCH net-next 1/6] ethernet: add a helper for assigning port addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YW5hkKVPiV20Ky+7@shredder>
Date:   Tue, 19 Oct 2021 09:11:28 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, olteanv@...il.com,
        andrew@...n.ch, f.fainelli@...il.com, snelson@...sando.io
Subject: Re: [PATCH net-next 1/6] ethernet: add a helper for assigning port
 addresses

On Mon, Oct 18, 2021 at 02:10:02PM -0700, Jakub Kicinski wrote:
> We have 5 drivers which offset base MAC addr by port id.
> Create a helper for them.
> 
> This helper takes care of overflows, which some drivers
> did not do, please complain if that's going to break
> anything!
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Ido Schimmel <idosch@...dia.com>

> --
>  - eth_hw_addr_set_port() -> eth_hw_addr_gen()
>  - id u8 -> unsigned int

Thanks!