netdev - Re: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzaAmvoT-n8pusycm_q1-Tp4B+KMxu3yw1BXkM3xHY2-HQ@mail.gmail.com>
Date:   Wed, 20 Oct 2021 10:46:27 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Wan Jiabing <wanjiabing@...o.com>, Shuah Khan <shuah@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>, kael_w@...h.net
Subject: Re: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers

On Mon, Oct 18, 2021 at 9:07 AM John Fastabend <john.fastabend@...il.com> wrote:
>
> Wan Jiabing wrote:
> > Fix following checkincludes.pl warning:
> > ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
> > tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
> > than once.
> >
> > Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> > ---
> > Changelog:
> > v2:
> > - Fix the commit description.
> > ---
>
> The Subject is a bit unusual. Typically it would be something like,
>
>  "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"

Also for selftests we use "selftests/bpf: " prefix (at least we
generally try, for consistency). Fixed up, applied to bpf-next.
Thanks.

>
> For the actual patch though LGTM.
>
> Acked-by: John Fastabend <john.fastabend@...il.com>