netdev - Re: [PATCH V2 mlx5-next 08/14] vfio: Add a macro for VFIO_DEVICE_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Oct 2021 10:35:27 +0300
From:   Yishai Hadas <yishaih@...dia.com>
To:     Alex Williamson <alex.williamson@...hat.com>
CC:     <bhelgaas@...gle.com>, <jgg@...dia.com>, <saeedm@...dia.com>,
        <linux-pci@...r.kernel.org>, <kvm@...r.kernel.org>,
        <netdev@...r.kernel.org>, <kuba@...nel.org>, <leonro@...dia.com>,
        <kwankhede@...dia.com>, <mgurtovoy@...dia.com>, <maorg@...dia.com>
Subject: Re: [PATCH V2 mlx5-next 08/14] vfio: Add a macro for
 VFIO_DEVICE_STATE_ERROR

On 10/19/2021 6:50 PM, Alex Williamson wrote:
> On Tue, 19 Oct 2021 09:48:20 -0600
> Alex Williamson <alex.williamson@...hat.com> wrote:
>
>> On Tue, 19 Oct 2021 13:58:32 +0300
>> Yishai Hadas <yishaih@...dia.com> wrote:
>>
>>> Add a macro for VFIO_DEVICE_STATE_ERROR to be used to set/check an error
>>> state.
>>>
>>> Signed-off-by: Yishai Hadas <yishaih@...dia.com>
>>> ---
>>>   include/uapi/linux/vfio.h | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
>>> index 114ffcefe437..6d41a0f011db 100644
>>> --- a/include/uapi/linux/vfio.h
>>> +++ b/include/uapi/linux/vfio.h
>>> @@ -631,6 +631,8 @@ struct vfio_device_migration_info {
>>>   	__u64 data_size;
>>>   };
>>>   
>>> +#define VFIO_DEVICE_STATE_ERROR (VFIO_DEVICE_STATE_SAVING | \
>>> +				 VFIO_DEVICE_STATE_RESUMING)
>> This should be with the other VFIO_DEVICE_STATE_foo #defines.  I'd
>> probably put it between _RESUMING and _MASK.  Thanks,
> This should also update the existing macros that include _SAVING |
> _RESUMING.  Thanks,
>
> Alex
>
Sure, will do as part of V3.

Yishai