netdev - DSA slaves not inheriting hw_enc_features and xfrmdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <CDEC9628-69B6-4A83-81CF-34407070214F@cs.com>
Date:   Wed, 20 Oct 2021 09:28:40 +0800
From:   R W van Schagen <vschagen@...com>
To:     netdev@...r.kernel.org
Subject: DSA slaves not inheriting hw_enc_features and xfrmdev_ops?

Hi all,

When I register a master device (eth0) with ESP hardware offload:

	netdev->xfrmdev_ops = &mtk_xfrmdev_ops;
	netdev->features |= NETIF_F_HW_ESP;
	netdev->hw_enc_features |= NETIF_F_HW_ESP;

Only the “features” are inherited by the DSA slaves. When those
get registered without the xfrmdev_ops the HW_ESP feature is
dropped again.

Is this a “bug” and should I make a patch to fix this or is this actually
a design feature?

As a work-around I am using a notifier call and add those features but
I don’t think this is the proper way to do this in a production driver.

Thanks
Richard van Schagen