netdev - Re: [PATCHv2 net] net: bridge: mcast: QRI must be less than QI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c041a184-92cb-0ebd-25e9-13bfc6413fc9@nvidia.com>
Date:   Wed, 20 Oct 2021 12:49:17 +0300
From:   Nikolay Aleksandrov <nikolay@...dia.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Nikolay Aleksandrov <razor@...ckwall.org>, roopa@...dia.com,
        bridge@...ts.linux-foundation.org, davem@...emloft.net,
        kuba@...nel.org
Subject: Re: [PATCHv2 net] net: bridge: mcast: QRI must be less than QI

On 20/10/2021 05:40, Hangbin Liu wrote:
> Based on RFC3376 8.3:
> The number of seconds represented by the [Query Response Interval]
> must be less than the [Query Interval].
> 
> Fixes: d902eee43f19 ("bridge: Add multicast count/interval sysfs entries")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  net/bridge/br_multicast.c    | 27 +++++++++++++++++++++++++++
>  net/bridge/br_netlink.c      |  8 ++++++--
>  net/bridge/br_private.h      |  4 ++++
>  net/bridge/br_sysfs_br.c     |  6 ++----
>  net/bridge/br_vlan_options.c |  8 ++++++--
>  5 files changed, 45 insertions(+), 8 deletions(-)
> 

Nacked-by: Nikolay Aleksandrov <nikolay@...dia.com>

I think we just discussed this a day ago? It is the same problem -
while we all agree the values should follow the RFC, users have had
the option to set any values forever (even non-RFC compliant ones).
This change risks breaking user-space.

Users are free to follow the RFC or not, we can't force them at this
point. This should've been done when the config option was added long
time ago.

Thanks,
 Nik