netdev - Re: [PATCH bpf-next 0/2] Support RENAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Oct 2021 17:14:01 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Lorenz Bauer <lmb@...udflare.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        kernel-team@...udflare.com, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next 0/2] Support RENAME_EXCHANGE on bpffs

On Wed, Oct 20, 2021 at 09:29:54AM +0100, Lorenz Bauer wrote:
> Add support for renameat2(RENAME_EXCHANGE) on bpffs. This is useful
> for atomic upgrades of our sk_lookup control plane.
> 
> * Create a temporary directory on bpffs
> * Migrate maps and pin them into temporary directory
> * Load new sk_lookup BPF, attach it and pin the link into temp dir
> * renameat2(temp dir, state dir, RENAME_EXCHANGE)
> * rmdir temp dir
> 
> Due to the sk_lookup semantics this means we can never end up in a
> situation where an upgrade breaks the existing control plane.

That is a cool idea.
The selftest doesn't exercise all of this logic.
It's only testing that RENAME_EXCHANGE works on directories within bpffs.
Do we need a test for other types of paths?