netdev - Re: [PATCH net-next 09/12] net: s390: constify and use eth_hw_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211021060508.44358d5a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 21 Oct 2021 06:05:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Julian Wiedmann <jwi@...ux.ibm.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kgraul@...ux.ibm.com,
        hca@...ux.ibm.com, gor@...ux.ibm.com, borntraeger@...ibm.com,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH net-next 09/12] net: s390: constify and use
 eth_hw_addr_set()

On Thu, 21 Oct 2021 00:30:23 +0200 Julian Wiedmann wrote:
> On 20.10.21 17:56, Jakub Kicinski wrote:
> > Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> > of VLANs...") introduced a rbtree for faster Ethernet address look
> > up. To maintain netdev->dev_addr in this tree we need to make all
> > the writes to it got through appropriate helpers.
> > 
> > Make sure local references to netdev->dev_addr are constant.
> >   
> 
> Acked-by: Julian Wiedmann <jwi@...ux.ibm.com>
> 
> Thanks Jakub. I suppose at some point __dev_addr_set() will then
> become more than just a memcpy, correct?

Yup, once all places are converted it will also adjust the position of
the address on the tree.