netdev - Re: DSA slaves not inheriting hw_enc_features and xfrmdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Oct 2021 15:11:32 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     R W van Schagen <vschagen@...com>
Cc:     netdev@...r.kernel.org
Subject: Re: DSA slaves not inheriting hw_enc_features and xfrmdev_ops?

> Thanks for the explanation. For now I will proceed using notifier callbacks.
> 
> One more strange thing I am noticing: Even if I set NETIF_F_GSO_ESP
> I am still not getting any GSO packets (skb_is_gso is always false) so my
> transmit speeds are like 2/3 of the receive speeds. Hardware Decryption vs
> Encryption is not 100% the same, but it is close.
> 
> I am getting the esp_gro_receive callbacks, but not the esp_gso_segment,
> BUT: for some reason my packets still get TCP GSO.

I'm not too familiar with GSO. But my understanding is that you create
a template set of headers which need to be placed onto each frame when
the segmentation actually happens. For DSA, that template would need
to include the DSA header. As far as i understand, there is nothing in
the DSA core that allows for adding the DSA headers into the template.
So you might be able to do GSO at the slave interface, but when the
slave passes frames to the master, you then require segmentation to
happen, so the tag driver can add the DSA header.

	Andrew