netdev - Re: [PATCH net] fcnal-test: kill hanging ping/nettest binaries on cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e7eecb2-0e14-f8c5-34df-6f1268cc2446@gmail.com>
Date:   Thu, 21 Oct 2021 08:42:59 -0600
From:   David Ahern <dsahern@...il.com>
To:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Cc:     dsahern@...nel.org
Subject: Re: [PATCH net] fcnal-test: kill hanging ping/nettest binaries on
 cleanup

On 10/21/21 8:02 AM, Florian Westphal wrote:
> On my box I see a bunch of ping/nettest processes hanging
> around after fcntal-test.sh is done.
> 
> Clean those up before netns deletion.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---
>  tools/testing/selftests/net/fcnal-test.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh
> index 13350cd5c8ac..5aba16c52c2b 100755
> --- a/tools/testing/selftests/net/fcnal-test.sh
> +++ b/tools/testing/selftests/net/fcnal-test.sh
> @@ -439,10 +439,13 @@ cleanup()
>  		ip -netns ${NSA} link set dev ${NSA_DEV} down
>  		ip -netns ${NSA} link del dev ${NSA_DEV}
>  
> +		ip netns pids ${NSA} | xargs kill 2>/dev/null
>  		ip netns del ${NSA}
>  	fi
>  
> +	ip netns pids ${NSB} | xargs kill 2>/dev/null
>  	ip netns del ${NSB}
> +	ip netns pids ${NSC} | xargs kill 2>/dev/null
>  	ip netns del ${NSC} >/dev/null 2>&1
>  }
>  
> 

Acked-by: David Ahern <dsahern@...nel.org>