netdev - Re: [PATCH net-next v3] net: marvell: prestera: add firmware v4.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211021161336.76885ef8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 21 Oct 2021 16:13:36 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>
Cc:     andrew@...n.ch, mickeyr@...vell.com, serhiy.pshyk@...ision.eu,
        taras.chornyi@...ision.eu, Volodymyr Mytnyk <vmytnyk@...vell.com>,
        Vadym Kochan <vkochan@...vell.com>,
        Yevhen Orlov <yevhen.orlov@...ision.eu>,
        Taras Chornyi <tchornyi@...vell.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] net: marvell: prestera: add firmware v4.0
 support

On Wed, 20 Oct 2021 12:32:28 +0300 Volodymyr Mytnyk wrote:
> +struct prestera_port_mac_state {
> +	bool oper;
> +	u32 mode;
> +	u32 speed;
> +	u8 duplex;
> +	u8 fc;
> +	u8 fec;
> +};
> +
> +struct prestera_port_phy_state {
> +	u64 lmode_bmap;
> +	struct {
> +		bool pause;
> +		bool asym_pause;
> +	} remote_fc;
> +	u8 mdix;
> +};
> +
> +struct prestera_port_mac_config {
> +	bool admin;
> +	u32 mode;
> +	u8 inband;
> +	u32 speed;
> +	u8 duplex;
> +	u8 fec;

Is it just me or these structures are offensively badly laid out?

pahole is your friend.

> +};
> +
> +/* TODO: add another parameters here: modes, etc... */
> +struct prestera_port_phy_config {
> +	bool admin;
> +	u32 mode;
> +	u8 mdix;
> +};