netdev - Re: [PATCH] sfc: Don't use netif_info before net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2fc87c9-570b-546a-5c7e-867b26b9840e@intel.com>
Date:   Thu, 21 Oct 2021 16:33:51 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Erik Ekman <erik@...o.se>, Edward Cree <ecree.xilinx@...il.com>,
        "Martin Habets" <habetsm.xilinx@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sfc: Don't use netif_info before net_device setup

On 10/19/2021 3:40 PM, Erik Ekman wrote:
> Use pci_info instead to avoid unnamed/uninitialized noise:
> 
> [197088.688729] sfc 0000:01:00.0: Solarflare NIC detected
> [197088.690333] sfc 0000:01:00.0: Part Number : SFN5122F
> [197088.729061] sfc 0000:01:00.0 (unnamed net_device) (uninitialized): no SR-IOV VFs probed
> [197088.729071] sfc 0000:01:00.0 (unnamed net_device) (uninitialized): no PTP support
> 
> Inspired by fa44821a4ddd ("sfc: don't use netif_info et al before
> net_device is registered") from Heiner Kallweit.
> 
> Signed-off-by: Erik Ekman <erik@...o.se>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>