netdev - Re: [PATCH net-next v3] mctp: Implement extended addressing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Oct 2021 11:45:36 +0800
From:   Jeremy Kerr <jk@...econstruct.com.au>
To:     Eugene Syromiatnikov <esyr@...hat.com>
Cc:     netdev@...r.kernel.org, Matt Johnston <matt@...econstruct.com.au>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v3] mctp: Implement extended addressing

Hi Eugene,

> So, unless there is existing code that relies on this socket level
> definition, it is probably worth re-defining it to 284 and put a copy
> of SOL_MCTP definition after SOL_XDP in include/linux/socket.h.

Nope, new ABI here, so we're fine to define it as we like.

I've sent a v4 with this moved to linux/socket.h, and dropped the uapi
definition - as (like you've mentioned) there's not a lot of precedent
for the copies under uapi.

Thanks for the review!

Cheers,

Jeremy