netdev - RE: [PATCH net] net: enetc: make sure all traffic classes can send large frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR04MB8395E7370B07F8D36B10026896BF9@DB9PR04MB8395.eurprd04.prod.outlook.com>
Date:   Thu, 21 Oct 2021 09:37:21 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Vladimir Oltean <vladimir.oltean@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
CC:     Richie Pearn <richard.pearn@....com>,
        Camelia Alexandra Groza <camelia.groza@....com>,
        Po Liu <po.liu@....com>
Subject: RE: [PATCH net] net: enetc: make sure all traffic classes can send
 large frames

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@....com>
> Sent: Wednesday, October 20, 2021 8:34 PM
[...]
> Subject: [PATCH net] net: enetc: make sure all traffic classes can send large
> frames
> 
> The enetc driver does not implement .ndo_change_mtu, instead it
> configures the MAC register field PTC{Traffic Class}MSDUR[MAXSDU]
> statically to a large value during probe time.
> 
> The driver used to configure only the max SDU for traffic class 0, and
> that was fine while the driver could only use traffic class 0. But with
> the introduction of mqprio, sending a large frame into any other TC than
> 0 is broken.
> 
> This patch fixes that by replicating per traffic class the static
> configuration done in enetc_configure_port_mac().
> 
> Fixes: cbe9e835946f ("enetc: Enable TC offloading with mqprio")
> Reported-by: Richie Pearn <richard.pearn@....com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---

Reviewed-by: <Claudiu Manoil <claudiu.manoil@....com>