netdev - Re: GENET and UNIMAC MDIO probe issue?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Oct 2021 09:27:49 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Stefan Wahren <stefan.wahren@...e.com>,
        Maxime Ripard <maxime@...no.tech>,
        Doug Berger <opendmb@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        Nicolas Saenz Julienne <nsaenz@...nel.org>
Subject: Re: GENET and UNIMAC MDIO probe issue?

On 10/22/21 8:35 AM, Stefan Wahren wrote:
> Hi Maxime,
> 
> Am 22.10.21 um 16:33 schrieb Maxime Ripard:
>> Hi Florian, Doug,
>>
>> I'm currently trying to make the RaspberryPi CM4 IO board probe its
>> ethernet controller, and it looks like genet doesn't manage to find its
>> PHY and errors out with:
>>
>> [    3.240435] libphy: Fixed MDIO Bus: probed
>> [    3.248849] bcmgenet fd580000.ethernet: GENET 5.0 EPHY: 0x0000
>> [    3.259118] libphy: bcmgenet MII bus: probed
>> [    3.278420] mdio_bus unimac-mdio--19: MDIO device at address 1 is missing.
>> [    3.285661] unimac-mdio unimac-mdio.-19: Broadcom UniMAC MDIO bus
>>
>> ....
>>
>> [   13.082281] could not attach to PHY
>> [   13.089762] bcmgenet fd580000.ethernet eth0: failed to connect to PHY
>> [   74.739621] could not attach to PHY
>> [   74.746492] bcmgenet fd580000.ethernet eth0: failed to connect to PHY
>>
>> Here's the full boot log:
>> https://pastebin.com/8RhuezSn
> 
> looks like you are using the vendor DTB, please use the upstream DTB
> from linux-next:
> 
> bcm2711-rpi-cm4-io.dtb

Stefan beat me to it, but yes, it looked like you had an Ethernet PHY at
MDIO address 25, when arch/arm/boot/dts/bcm2711-rpi-cm4.dtsi indicates
that it should be at address 0, therefore it won't work.

The issue with mdio-bcm-unimac not being loaded would only be applicable
in a modular case anyway, when it is built-in, there would be no such
problem. Let me know if there are other changes that are necessary, DTS
or else.
-- 
Florian