netdev - Re: [PATCH linux-next] octeontx2-af: Remove redundant assignment operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211022110854.21052cb6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 22 Oct 2021 11:08:54 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     luo penghao <cgel.zte@...il.com>
Cc:     SimonHorman <horms@...nel.org>,
        Mirko Lindner <mlindner@...vell.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        luo penghao <luo.penghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] octeontx2-af: Remove redundant assignment
 operations

On Thu, 21 Oct 2021 06:50:19 +0000 luo penghao wrote:
> The variable err will be reassigned on subsequent branches, and this
> assignment does not perform related value operations.
> 
> clang_analyzer complains as follows:
> 
> drivers/net/ethernet/marvell/sky2.c:4988: warning:
> 
> Although the value stored to 'err' is used in the enclosing expression,
> the value is never actually read from 'err'.

Oh you did CC Mirko on this version.. Do you not have the CCs automated?
scripts/get_maintainer.pl is your friend.

If you're posting a new version of the patch please put [PATCH v2] as
the subject prefix. And stop putting the pointless linux-next there.

Thanks.