netdev - Re: [PATCH net-next] net: phy: microchip_t1: add cable test support for lan87xx phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YXMVdkXIenVuD3gV@lunn.ch>
Date:   Fri, 22 Oct 2021 21:48:06 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Yuiko Oshino <yuiko.oshino@...rochip.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        nisar.sayed@...rochip.com, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next] net: phy: microchip_t1: add cable test support
 for lan87xx phy

> +/* MISC Control 1 Register */
> +#define LAN87XX_CTRL_1                          (0x11)
> +#define LAN87XX_MASK_RGMII_TXC_DLY_EN           (0x4000)
> +#define LAN87XX_MASK_RGMII_RXC_DLY_EN           (0x2000)

Interesting to know, but not used in this patch.

Please can you write a patch to actually make use of these bits, and
do the right thing when phydev->interface is one of the four
PHY_INTERFACE_MODE_RGMII values.

	 Andrew