netdev - Re: [PATCH v6 2/3] net: ndisc: introduce ndisc_evict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b2b8f0e5648a237722c5f3cb6c6d2d8542f1054.camel@gmail.com>
Date:   Fri, 22 Oct 2021 14:03:27 -0700
From:   James Prestwood <prestwoj@...il.com>
To:     netdev@...r.kernel.org
Subject: Re: [PATCH v6 2/3] net: ndisc: introduce ndisc_evict_nocarrier
 sysctl parameter

[snip]

> @@ -1810,10 +1811,19 @@ static int ndisc_netdev_event(struct
> notifier_block *this, unsigned long event,
>                 in6_dev_put(idev);
>                 break;
>         case NETDEV_CHANGE:
> +               idev = in6_dev_get(dev);
> +               if (!idev)
> +                       evict_nocarrier = true;
> +               else {
> +                       evict_nocarrier = idev-
> >cnf.ndisc_evict_nocarrier ||
> +                                         net->ipv6.devconf_all-
> >ndisc_evict_nocarrier;

Whoops, this should be &&

> +                       in6_dev_put(idev);
> +               }
> +
>                 change_info = ptr;
>                 if (change_info->flags_changed & IFF_NOARP)
>                         neigh_changeaddr(&nd_tbl, dev);
> -               if (!netif_carrier_ok(dev))
> +               if (evict_nocarrier && !netif_carrier_ok(dev))
>                         neigh_carrier_down(&nd_tbl, dev);
>                 break;
>         case NETDEV_DOWN: