netdev - Re: [PATCH net-next v3] net: marvell: prestera: add firmware v4.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Oct 2021 22:07:37 +0000
From:   "Volodymyr Mytnyk [C]" <vmytnyk@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "andrew@...n.ch" <andrew@...n.ch>,
        Mickey Rachamim <mickeyr@...vell.com>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        "Vadym Kochan [C]" <vkochan@...vell.com>,
        Yevhen Orlov <yevhen.orlov@...ision.eu>,
        "Taras Chornyi [C]" <tchornyi@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3] net: marvell: prestera: add firmware v4.0
 support

>
> > +struct prestera_port_mac_state {
> > +     bool oper;
> > +     u32 mode;
> > +     u32 speed;
> > +     u8 duplex;
> > +     u8 fc;
> > +     u8 fec;
> > +};
> > +
> > +struct prestera_port_phy_state {
> > +     u64 lmode_bmap;
> > +     struct {
> > +             bool pause;
> > +             bool asym_pause;
> > +     } remote_fc;
> > +     u8 mdix;
> > +};
> > +
> > +struct prestera_port_mac_config {
> > +     bool admin;
> > +     u32 mode;
> > +     u8 inband;
> > +     u32 speed;
> > +     u8 duplex;
> > +     u8 fec;
> 
> Is it just me or these structures are offensively badly laid out?
> 
> pahole is your friend.

Thanks! will fix it in next patch set.

> 
> > +};
> > +
> > +/* TODO: add another parameters here: modes, etc... */
> > +struct prestera_port_phy_config {
> > +     bool admin;
> > +     u32 mode;
> > +     u8 mdix;
> > +};

  Volodymyr