netdev - Re: [PATCH 2/2] wcn36xx: add missing 5GHz channels 136 and 144

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f060ea87-12d8-afaf-fc7d-2b2fd461b7e7@linaro.org>
Date:   Sat, 23 Oct 2021 10:55:48 +0100
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Benjamin Li <benl@...areup.com>, Kalle Valo <kvalo@...eaurora.org>
Cc:     Loic Poulain <loic.poulain@...aro.org>,
        linux-arm-msm@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, wcn36xx@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] wcn36xx: add missing 5GHz channels 136 and 144

On 23/10/2021 00:57, Benjamin Li wrote:
> These channels missing from scan results are a regression from downstream
> prima.
> 
> Signed-off-by: Benjamin Li <benl@...areup.com>
> ---
>   drivers/net/wireless/ath/wcn36xx/main.c | 2 ++
>   drivers/net/wireless/ath/wcn36xx/smd.c  | 1 +
>   2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index 263af65a889a..13d09c66ae92 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -85,7 +85,9 @@ static struct ieee80211_channel wcn_5ghz_channels[] = {
>   	CHAN5G(5620, 124, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_HIGH),
>   	CHAN5G(5640, 128, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_HIGH),
>   	CHAN5G(5660, 132, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_LOW),
> +	CHAN5G(5680, 136, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_LOW),
>   	CHAN5G(5700, 140, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_HIGH),
> +	CHAN5G(5720, 144, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_HIGH),
>   	CHAN5G(5745, 149, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_LOW),
>   	CHAN5G(5765, 153, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_LOW),
>   	CHAN5G(5785, 157, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_HIGH),
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index be6442b3c80b..9785327593d2 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -2396,6 +2396,7 @@ int wcn36xx_smd_feature_caps_exchange(struct wcn36xx *wcn)
>   	set_feat_caps(msg_body.feat_caps, STA_POWERSAVE);
>   	if (wcn->rf_id == RF_IRIS_WCN3680) {
>   		set_feat_caps(msg_body.feat_caps, DOT11AC);
> +		set_feat_caps(msg_body.feat_caps, WLAN_CH144);
>   		set_feat_caps(msg_body.feat_caps, ANTENNA_DIVERSITY_SELECTION);
>   	}
>   
> 

LGTM

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>