netdev - Re: [PATCH net] net: Prevent infinite while loop in skb_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163517400727.18146.17098840029288266871.git-patchwork-notify@kernel.org>
Date:   Mon, 25 Oct 2021 15:00:07 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kuba@...nel.org,
        gospo@...adcom.com
Subject: Re: [PATCH net] net: Prevent infinite while loop in skb_tx_hash()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Mon, 25 Oct 2021 05:05:28 -0400 you wrote:
> Drivers call netdev_set_num_tc() and then netdev_set_tc_queue()
> to set the queue count and offset for each TC.  So the queue count
> and offset for the TCs may be zero for a short period after dev->num_tc
> has been set.  If a TX packet is being transmitted at this time in the
> code path netdev_pick_tx() -> skb_tx_hash(), skb_tx_hash() may see
> nonzero dev->num_tc but zero qcount for the TC.  The while loop that
> keeps looping while hash >= qcount will not end.
> 
> [...]

Here is the summary with links:
  - [net] net: Prevent infinite while loop in skb_tx_hash()
    https://git.kernel.org/netdev/net/c/0c57eeecc559

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html