netdev - Re: [PATCH 3/4] rtl8187: fix control-message timeouts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1202359771.1685642.1635189110010@mail.yahoo.com>
Date:   Mon, 25 Oct 2021 19:11:50 +0000 (UTC)
From:   Hin-Tak Leung <htl10@...rs.sourceforge.net>
To:     Johan Hovold <johan@...nel.org>, Kalle Valo <kvalo@...eaurora.org>
Cc:     Herton Ronaldo Krzesinski <herton@...onical.com>,
        Larry Finger <larry.finger@...inger.net>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        Siva Rebbagondla <siva8118@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Johan Hovold <johan@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH 3/4] rtl8187: fix control-message timeouts

> USB control-message timeouts are specified in milliseconds and should
> specifically not vary with CONFIG_HZ.

> Fixes: 605bebe23bf6 ("[PATCH] Add rtl8187 wireless driver")
> Cc: stable@...r.kernel.org      # 2.6.23
> Signed-off-by: Johan Hovold <johan@...nel.org>

Acked-by: Hin-Tak Leung <htl10@...rs.sourceforge.net>

> ---
> .../net/wireless/realtek/rtl818x/rtl8187/rtl8225.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)

> diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
> index 585784258c66..4efab907a3ac 100644
> --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
> +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
> @@ -28,7 +28,7 @@ u8 rtl818x_ioread8_idx(struct rtl8187_priv *priv,
>     usb_control_msg(priv->udev, usb_rcvctrlpipe(priv->udev, 0),
>             RTL8187_REQ_GET_REG, RTL8187_REQT_READ,
>             (unsigned long)addr, idx & 0x03,
> -            &priv->io_dmabuf->bits8, sizeof(val), HZ / 2);
> +            &priv->io_dmabuf->bits8, sizeof(val), 500);

Looks reasonable, although I would have preferred a common defined value taken from a common header, instead of a hard-coded 1/2 second.