netdev - Re: [PATCH net] net-sysfs: initialize uid and gid before calling net_ns_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211025084603.36owzqhkfhwyrmro@wittgenstein>
Date:   Mon, 25 Oct 2021 10:46:03 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, davem@...emloft.net,
        kuba@...nel.org, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] net-sysfs: initialize uid and gid before calling
 net_ns_get_ownership

On Mon, Oct 25, 2021 at 02:31:48AM -0400, Xin Long wrote:
> Currently in net_ns_get_ownership() it may not be able to set uid or gid
> if make_kuid or make_kgid returns an invalid value, and an uninit-value
> issue can be triggered by this.
> 
> This patch is to fix it by initializing the uid and gid before calling
> net_ns_get_ownership(), as it does in kobject_get_ownership()
> 
> Fixes: e6dee9f3893c ("net-sysfs: add netdev_change_owner()")
> Reported-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> ---

Looks good,
Acked-by: Christian Brauner <christian.brauner@...ntu.com>