netdev - Re: [PATCH] ath10k: fix invalid dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Oct 2021 09:16:47 -0300
From:   Fabio Estevam <festevam@...x.de>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        Alagu Sankar <alagusankar@...ex-india.com>,
        Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Brian Norris <briannorris@...omium.org>,
        Wen Gong <wgong@...eaurora.org>,
        Tamizh Chelvam <tamizhr@...eaurora.org>,
        Carl Huang <cjhuang@...eaurora.org>,
        Miaoqing Pan <miaoqing@...eaurora.org>,
        Ben Greear <greearb@...delatech.com>,
        Erik Stromdahl <erik.stromdahl@...il.com>,
        ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ath10k: fix invalid dma_addr_t token assignment

On 14/10/2021 04:51, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Using a kernel pointer in place of a dma_addr_t token can
> lead to undefined behavior if that makes it into cache
> management functions. The compiler caught one such attempt
> in a cast:
> 
> drivers/net/wireless/ath/ath10k/mac.c: In function 
> 'ath10k_add_interface':
> drivers/net/wireless/ath/ath10k/mac.c:5586:47: error: cast from
> pointer to integer of different size [-Werror=pointer-to-int-cast]
>  5586 |                         arvif->beacon_paddr =
> (dma_addr_t)arvif->beacon_buf;
>       |                                               ^
> 
> Looking through how this gets used down the way, I'm fairly
> sure that beacon_paddr is never accessed again for ATH10K_DEV_TYPE_HL
> devices, and if it was accessed, that would be a bug.
> 
> Change the assignment to use a known-invalid address token
> instead, which avoids the warning and makes it easier to catch
> bugs if it does end up getting used.
> 
> Fixes: e263bdab9c0e ("ath10k: high latency fixes for beacon buffer")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Fabio Estevam <festevam@...x.de>