netdev - Re: [PATCH net-next v3] amt: add initial driver for Automatic Multicast Tunneling (AMT)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Oct 2021 21:39:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Taehee Yoo <ap420073@...il.com>, davem@...emloft.net,
        kuba@...nel.org, dsahern@...nel.org, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, ap420073@...il.com
Subject: Re: [PATCH net-next v3] amt: add initial driver for Automatic
 Multicast Tunneling (AMT)

Hi Taehee,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Taehee-Yoo/amt-add-initial-driver-for-Automatic-Multicast-Tunneling-AMT/20211026-161354
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 36d935a0a67e4456bd84943319718448c9647675
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/dd5f44f1fa0fb160dc1e3b6a848b7dc0b9c6a602
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Taehee-Yoo/amt-add-initial-driver-for-Automatic-Multicast-Tunneling-AMT/20211026-161354
        git checkout dd5f44f1fa0fb160dc1e3b6a848b7dc0b9c6a602
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from drivers/net/amt.c:20:
>> include/net/amt.h:137:17: error: expected specifier-qualifier-list before 'reserved2'
     137 |                 reserved2:16;
         |                 ^~~~~~~~~
   drivers/net/amt.c: In function 'amt_send_request':
>> drivers/net/amt.c:760:16: error: 'struct amt_header_request' has no member named 'reserved2'; did you mean 'reserved1'?
     760 |         amtrh->reserved2 = 0;
         |                ^~~~~~~~~
         |                reserved1
>> drivers/net/amt.c:761:14: error: 'struct amt_header_request' has no member named 'nonce'
     761 |         amtrh->nonce     = amt->nonce;
         |              ^~
   drivers/net/amt.c: In function 'amt_request_handler':
   drivers/net/amt.c:2638:40: error: 'struct amt_header_request' has no member named 'reserved2'; did you mean 'reserved1'?
    2638 |         if (amtrh->reserved1 || amtrh->reserved2 || amtrh->version)
         |                                        ^~~~~~~~~
         |                                        reserved1
   drivers/net/amt.c:2680:30: error: 'struct amt_header_request' has no member named 'nonce'
    2680 |         tunnel->nonce = amtrh->nonce;
         |                              ^~


vim +/reserved2 +137 include/net/amt.h

   124	
   125	struct amt_header_request {
   126	#if defined(__LITTLE_ENDIAN_BITFIELD)
   127		u32	type:4,
   128			version:4,
   129			reserved1:7,
   130			p:1,
   131			reserved2:16;
   132	#elif defined(__BIG_ENDIAN_BITFIELD)
   133		u32	version:4,
   134			type:4,
   135			p:1,
   136			reserved1:7;
 > 137			reserved2:16;
   138	#else
   139	#error  "Please fix <asm/byteorder.h>"
   140	#endif
   141		__be32	nonce;
   142	} __packed;
   143	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (61717 bytes)