netdev - Re: [RESEND PATCH v7 3/3] selftests: net: add arp_ndisc_evict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea4d34ea-6393-97c9-5484-f703a4f5cea6@gmail.com>
Date:   Tue, 26 Oct 2021 08:57:11 -0600
From:   David Ahern <dsahern@...il.com>
To:     James Prestwood <prestwoj@...il.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, corbet@....net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, roopa@...dia.com,
        daniel@...earbox.net, vladimir.oltean@....com, idosch@...dia.com,
        nikolay@...dia.com, yajun.deng@...ux.dev, zhutong@...zon.com,
        johannes@...solutions.net, jouni@...eaurora.org
Subject: Re: [RESEND PATCH v7 3/3] selftests: net: add
 arp_ndisc_evict_nocarrier

On 10/25/21 10:45 AM, James Prestwood wrote:
> This tests the sysctl options for ARP/ND:
> 
> /net/ipv4/conf/<iface>/arp_evict_nocarrier
> /net/ipv6/conf/<iface>/ndisc_evict_nocarrier
> 
> Signed-off-by: James Prestwood <prestwoj@...il.com>
> ---
>  .../net/arp_ndisc_evict_nocarrier.sh          | 181 ++++++++++++++++++
>  1 file changed, 181 insertions(+)
>  create mode 100755 tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
> 

Thanks for adding the selftests.

The tests should include a set with the 'all' setting as well -- off and
on works as expected. If you have to do another version, you can add it
then. If this version gets committed, please send a followup patch with
those tests.

Reviewed-by: David Ahern <dsahern@...nel.org>