netdev - Re: [PATCH bpf-next] selftests/bpf: Skip all serial_test_get_branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzajKH1gSo_MNoYb5GfnAy-o_P2viNuQSMUywrU4MPFbjg@mail.gmail.com>
Date:   Mon, 25 Oct 2021 20:45:36 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Song Liu <songliubraving@...com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] selftests/bpf: Skip all serial_test_get_branch_snapshot
 in vm

On Mon, Oct 25, 2021 at 5:07 PM Song Liu <songliubraving@...com> wrote:
>
> Skipping the second half of the test is not enough to silent the warning
> in dmesg. Skip the whole test before we can either properly silent the
> warning in kernel, or fix LBR snapshot for VM.
>
> Fixes: 025bd7c753aa ("selftests/bpf: Add test for bpf_get_branch_snapshot")
> Fixes: aa67fdb46436 ("selftests/bpf: Skip the second half of get_branch_snapshot in vm")
> Signed-off-by: Song Liu <songliubraving@...com>
> ---

Applied to bpf-next, thanks for the fix!

>  .../bpf/prog_tests/get_branch_snapshot.c         | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/get_branch_snapshot.c b/tools/testing/selftests/bpf/prog_tests/get_branch_snapshot.c
> index d6d70a359aeb5..81402e4439844 100644
> --- a/tools/testing/selftests/bpf/prog_tests/get_branch_snapshot.c
> +++ b/tools/testing/selftests/bpf/prog_tests/get_branch_snapshot.c
> @@ -78,6 +78,12 @@ void serial_test_get_branch_snapshot(void)
>         struct get_branch_snapshot *skel = NULL;
>         int err;
>
> +       /* Skip the test before we fix LBR snapshot for hypervisor. */
> +       if (is_hypervisor()) {
> +               test__skip();
> +               return;
> +       }
> +
>         if (create_perf_events()) {
>                 test__skip();  /* system doesn't support LBR */
>                 goto cleanup;
> @@ -107,16 +113,6 @@ void serial_test_get_branch_snapshot(void)
>                 goto cleanup;
>         }
>
> -       if (is_hypervisor()) {
> -               /* As of today, LBR in hypervisor cannot be stopped before
> -                * too many entries are flushed. Skip the hit/waste test
> -                * for now in hypervisor until we optimize the LBR in
> -                * hypervisor.
> -                */
> -               test__skip();
> -               goto cleanup;
> -       }
> -
>         ASSERT_GT(skel->bss->test1_hits, 6, "find_looptest_in_lbr");
>
>         /* Given we stop LBR in software, we will waste a few entries.
> --
> 2.30.2
>