netdev - Re: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Oct 2021 10:34:38 +0100
From:   "Colin King (gmail)" <colin.i.king@...glemail.com>
To:     Denis Kirjanov <dkirjanov@...e.de>,
        Colin Ian King <colin.i.king@...glemail.com>,
        Jeroen de Borst <jeroendb@...gle.com>,
        Catherine Sullivan <csully@...gle.com>,
        David Awogbemila <awogbemila@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"

On 26/10/2021 10:32, Denis Kirjanov wrote:
> 
> 
> 10/26/21 12:22 PM, Colin Ian King пишет:
>> There is a spelling mistake in a netdev_warn message. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> 
> you could fix the second instance as well:

Will do. Thanks for noting that :-)

> 
> grep -nri droping drivers/net/
> drivers/net/wireless/mac80211_hwsim.c:1279:        /* Droping until 
> WARN_QUEUE level */
> drivers/net/ethernet/google/gve/gve_rx.c:441:                    "RX 
> fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.",
> 
> 
>> ---
>>   drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/google/gve/gve_rx.c 
>> b/drivers/net/ethernet/google/gve/gve_rx.c
>> index c8500babbd1d..ef4aa6487c55 100644
>> --- a/drivers/net/ethernet/google/gve/gve_rx.c
>> +++ b/drivers/net/ethernet/google/gve/gve_rx.c
>> @@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx 
>> *ctx, struct gve_rx_ring *rx)
>>           if (frag_size > rx->packet_buffer_size) {
>>               packet_size_error = true;
>>               netdev_warn(priv->dev,
>> -                    "RX fragment error: packet_buffer_size=%d, 
>> frag_size=%d, droping packet.",
>> +                    "RX fragment error: packet_buffer_size=%d, 
>> frag_size=%d, dropping packet.",
>>                       rx->packet_buffer_size, be16_to_cpu(desc->len));
>>           }
>>           page_info = &rx->data.page_info[idx];
>>