netdev - RE: [PATCH net-next] net: phy: microchip_t1: add cable test support for lan87xx phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH0PR11MB55611B20B0E62E95C74027338E859@CH0PR11MB5561.namprd11.prod.outlook.com>
Date:   Wed, 27 Oct 2021 14:21:50 +0000
From:   <Yuiko.Oshino@...rochip.com>
To:     <andrew@...n.ch>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <Nisar.Sayed@...rochip.com>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH net-next] net: phy: microchip_t1: add cable test support
 for lan87xx phy

>-----Original Message-----
>From: Andrew Lunn <andrew@...n.ch>
>Sent: Friday, October 22, 2021 3:48 PM
>To: Yuiko Oshino - C18177 <Yuiko.Oshino@...rochip.com>
>Cc: davem@...emloft.net; netdev@...r.kernel.org; Nisar Sayed - I17970
><Nisar.Sayed@...rochip.com>; UNGLinuxDriver
><UNGLinuxDriver@...rochip.com>
>Subject: Re: [PATCH net-next] net: phy: microchip_t1: add cable test support for
>lan87xx phy
>
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>content is safe
>
>> +/* MISC Control 1 Register */
>> +#define LAN87XX_CTRL_1                          (0x11)
>> +#define LAN87XX_MASK_RGMII_TXC_DLY_EN           (0x4000)
>> +#define LAN87XX_MASK_RGMII_RXC_DLY_EN           (0x2000)
>
>Interesting to know, but not used in this patch.
>
>Please can you write a patch to actually make use of these bits, and do the right
>thing when phydev->interface is one of the four PHY_INTERFACE_MODE_RGMII
>values.
>
>         Andrew

Thank you, Andrew.
We will consider to make a use of these in another patch.
Yuiko