netdev - Re: [PATCH net-next 0/8] Bridge FDB refactoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+h21hpgA8_0iMqQ03BhgnBeB8-nTxHo3LiF16VKj3A5yMaSQg@mail.gmail.com>
Date:   Wed, 27 Oct 2021 17:49:39 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Nikolay Aleksandrov <nikolay@...dia.com>
Cc:     patchwork-bot+netdevbpf@...nel.org,
        Vladimir Oltean <vladimir.oltean@....com>,
        netdev <netdev@...r.kernel.org>,
        Ido Schimmel <idosch@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Roopa Prabhu <roopa@...dia.com>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next 0/8] Bridge FDB refactoring

On Wed, 27 Oct 2021 at 17:46, Vladimir Oltean <olteanv@...il.com> wrote:
>
> On Wed, 27 Oct 2021 at 17:44, Nikolay Aleksandrov <nikolay@...dia.com> wrote:
> >
> > On 27/10/2021 17:40, patchwork-bot+netdevbpf@...nel.org wrote:
> > > Hello:
> > >
> > > This series was applied to netdev/net-next.git (master)
> > > by David S. Miller <davem@...emloft.net>:
> > >
> > > On Tue, 26 Oct 2021 17:27:35 +0300 you wrote:
> > >> This series refactors the br_fdb.c, br_switchdev.c and switchdev.c files
> > >> to offer the same level of functionality with a bit less code, and to
> > >> clarify the purpose of some functions.
> > >>
> > >> No functional change intended.
> > >>
> > >> Vladimir Oltean (8):
> > >>   net: bridge: remove fdb_notify forward declaration
> > >>   net: bridge: remove fdb_insert forward declaration
> > >>   net: bridge: rename fdb_insert to fdb_add_local
> > >>   net: bridge: rename br_fdb_insert to br_fdb_add_local
> > >>   net: bridge: reduce indentation level in fdb_create
> > >>   net: bridge: move br_fdb_replay inside br_switchdev.c
> > >>   net: bridge: create a common function for populating switchdev FDB
> > >>     entries
> > >>   net: switchdev: merge switchdev_handle_fdb_{add,del}_to_device
> > >>
> > >> [...]
> > >
> > > Here is the summary with links:
> > >   - [net-next,1/8] net: bridge: remove fdb_notify forward declaration
> > >     https://git.kernel.org/netdev/net-next/c/4682048af0c8
> > >   - [net-next,2/8] net: bridge: remove fdb_insert forward declaration
> > >     https://git.kernel.org/netdev/net-next/c/5f94a5e276ae
> > >   - [net-next,3/8] net: bridge: rename fdb_insert to fdb_add_local
> > >     https://git.kernel.org/netdev/net-next/c/4731b6d6b257
> > >   - [net-next,4/8] net: bridge: rename br_fdb_insert to br_fdb_add_local
> > >     https://git.kernel.org/netdev/net-next/c/f6814fdcfe1b
> > >   - [net-next,5/8] net: bridge: reduce indentation level in fdb_create
> > >     https://git.kernel.org/netdev/net-next/c/9574fb558044
> > >   - [net-next,6/8] net: bridge: move br_fdb_replay inside br_switchdev.c
> > >     https://git.kernel.org/netdev/net-next/c/5cda5272a460
> > >   - [net-next,7/8] net: bridge: create a common function for populating switchdev FDB entries
> > >     https://git.kernel.org/netdev/net-next/c/fab9eca88410
> > >   - [net-next,8/8] net: switchdev: merge switchdev_handle_fdb_{add,del}_to_device
> > >     https://git.kernel.org/netdev/net-next/c/716a30a97a52
> > >
> > > You are awesome, thank you!
> > >
> >
> > There was a discussion about patch 06 which we agreed have to turn into its own series
> > with more changes. Vladimir, since the set got applied please send a follow-up to
> > finish those changes.
>
> Wait a minute, even I got the impression that the next series I'll be
> sending would be completely separate from this one...

To be clear, what I'm preparing for that second series is to:
- move all of br_vlan_replay, br_mdb_replay into br_switchdev.c
- consistently name all functions to br_switchdev_*
- refactor the switchdev logic from br_mdb_notify into a new
br_switchdev_mdb_notify for symmetry with fdb_notify and
br_switchdev_fdb_notify
But I'm still working on it, because the VLAN and IGMP snooping code
is conditionally compiled, making it a bit harder :)

So the current placement of the br_fdb_replay function is not bad,
according to the follow-up changes I am going to make.