netdev - Re: [PATCH V5 mlx5-next 07/13] vfio: Add a macro for VFIO_DEVICE_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Oct 2021 18:30:39 +0300
From:   Max Gurtovoy <mgurtovoy@...dia.com>
To:     Yishai Hadas <yishaih@...dia.com>, <alex.williamson@...hat.com>,
        <bhelgaas@...gle.com>, <jgg@...dia.com>, <saeedm@...dia.com>
CC:     <linux-pci@...r.kernel.org>, <kvm@...r.kernel.org>,
        <netdev@...r.kernel.org>, <kuba@...nel.org>, <leonro@...dia.com>,
        <kwankhede@...dia.com>, <maorg@...dia.com>,
        Cornelia Huck <cohuck@...hat.com>
Subject: Re: [PATCH V5 mlx5-next 07/13] vfio: Add a macro for
 VFIO_DEVICE_STATE_ERROR


On 10/27/2021 12:56 PM, Yishai Hadas wrote:
> Add a macro for VFIO_DEVICE_STATE_ERROR to be used to set/check an error
> state.
>
> In addition, update existing macros that include _SAVING | _RESUMING to
> use it.
>
> Reviewed-by: Cornelia Huck <cohuck@...hat.com>
> Signed-off-by: Yishai Hadas <yishaih@...dia.com>
> ---
>   include/uapi/linux/vfio.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
> index 114ffcefe437..63ab0b9abd94 100644
> --- a/include/uapi/linux/vfio.h
> +++ b/include/uapi/linux/vfio.h
> @@ -609,6 +609,8 @@ struct vfio_device_migration_info {
>   #define VFIO_DEVICE_STATE_RUNNING   (1 << 0)
>   #define VFIO_DEVICE_STATE_SAVING    (1 << 1)
>   #define VFIO_DEVICE_STATE_RESUMING  (1 << 2)
> +#define VFIO_DEVICE_STATE_ERROR (VFIO_DEVICE_STATE_SAVING | \
> +				 VFIO_DEVICE_STATE_RESUMING)
>   #define VFIO_DEVICE_STATE_MASK      (VFIO_DEVICE_STATE_RUNNING | \
>   				     VFIO_DEVICE_STATE_SAVING |  \
>   				     VFIO_DEVICE_STATE_RESUMING)
> @@ -618,12 +620,10 @@ struct vfio_device_migration_info {
>   	(state & VFIO_DEVICE_STATE_MASK) == VFIO_DEVICE_STATE_RESUMING : 1)
>   
>   #define VFIO_DEVICE_STATE_IS_ERROR(state) \
> -	((state & VFIO_DEVICE_STATE_MASK) == (VFIO_DEVICE_STATE_SAVING | \
> -					      VFIO_DEVICE_STATE_RESUMING))
> +	((state & VFIO_DEVICE_STATE_MASK) == (VFIO_DEVICE_STATE_ERROR))
>   
>   #define VFIO_DEVICE_STATE_SET_ERROR(state) \
> -	((state & ~VFIO_DEVICE_STATE_MASK) | VFIO_DEVICE_STATE_SAVING | \
> -					     VFIO_DEVICE_STATE_RESUMING)
> +	((state & ~VFIO_DEVICE_STATE_MASK) | VFIO_DEVICE_STATE_ERROR)
>   
>   	__u32 reserved;
>   	__u64 pending_bytes;

Looks good,

Reviewed-by: Max Gurtovoy <mgurtovoy@...dia.com>