netdev - Re: [PATCH ethtool 2/2] netlink: settings: Drop port filter for MDI-X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Oct 2021 22:17:31 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     bage@...utronix.de
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ethtool 2/2] netlink: settings: Drop port filter for MDI-X

On Wed, Oct 27, 2021 at 09:59:23PM +0200, Michal Kubecek wrote:
> How about replacing "port == PORT_TP" with
> 
>   (port == TP || mdix != ETH_TP_MDI_INVALID || mdix_ctrl != ETH_TP_MDI_INVALID)
> 
> in both code path and probably moving the check into dump_mdix()?

Looking at the code again, we cannot move the check into dump_mdix()
easily as decision if print_banner(nlctx) should be called depends on
its result.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)