netdev - Re: [PATCH 1/3] virtio: cache indirect desc for split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Oct 2021 07:02:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH 1/3] virtio: cache indirect desc for split

Hi Xuan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on horms-ipvs/master]
[also build test WARNING on linus/master v5.15-rc7 next-20211027]
[cannot apply to mst-vhost/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8935e116c155fb7d484bad35a42b2ca98f75e384
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xuan-Zhuo/virtio-support-cache-indirect-desc/20211027-142025
        git checkout 8935e116c155fb7d484bad35a42b2ca98f75e384
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/virtio/virtio_ring.c: In function 'desc_cache_chain_free_split':
>> drivers/virtio/virtio_ring.c:438:25: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     438 |                 chain = (void *)desc->addr;
         |                         ^
   drivers/virtio/virtio_ring.c: In function 'desc_cache_put_split':
>> drivers/virtio/virtio_ring.c:447:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     447 |                 desc->addr = (u64)vq->desc_cache_chain;
         |                              ^
   drivers/virtio/virtio_ring.c: In function 'alloc_indirect_split':
   drivers/virtio/virtio_ring.c:464:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     464 |                         vq->desc_cache_chain = (void *)desc->addr;
         |                                                ^


vim +438 drivers/virtio/virtio_ring.c

   431	
   432	static void desc_cache_chain_free_split(void *chain)
   433	{
   434		struct vring_desc *desc;
   435	
   436		while (chain) {
   437			desc = chain;
 > 438			chain = (void *)desc->addr;
   439			kfree(desc);
   440		}
   441	}
   442	
   443	static void desc_cache_put_split(struct vring_virtqueue *vq,
   444					 struct vring_desc *desc, int n)
   445	{
   446		if (vq->use_desc_cache && n <= VIRT_QUEUE_CACHE_DESC_NUM) {
 > 447			desc->addr = (u64)vq->desc_cache_chain;
   448			vq->desc_cache_chain = desc;
   449		} else {
   450			kfree(desc);
   451		}
   452	}
   453	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (55358 bytes)