netdev - Re: [PATCH net-next 03/19] bnxt_en: implement devlink dev reload driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202110271618.EKpGYUYs-lkp@intel.com>
Date:   Wed, 27 Oct 2021 16:49:54 +0800
From:   kernel test robot <lkp@...el.com>
To:     Michael Chan <michael.chan@...adcom.com>, davem@...emloft.net
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org, kuba@...nel.org,
        edwin.peer@...adcom.com, gospo@...adcom.com, jiri@...dia.com
Subject: Re: [PATCH net-next 03/19] bnxt_en: implement devlink dev reload
 driver_reinit

Hi Michael,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Michael-Chan/bnxt_en-devlink-enhancements/20211024-111540
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git ab98bbee072c7c30c391ae742b209efebb468273
config: alpha-randconfig-r033-20211027 (attached as .config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/549adc3ba648357414ab9a43f9a1b06b706c819a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michael-Chan/bnxt_en-devlink-enhancements/20211024-111540
        git checkout 549adc3ba648357414ab9a43f9a1b06b706c819a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_request_irq':
   drivers/net/ethernet/broadcom/bnxt/bnxt.c:8999:16: warning: variable 'j' set but not used [-Wunused-but-set-variable]
    8999 |         int i, j, rc = 0;
         |                ^
   drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_remove_one':
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:12762:9: error: implicit declaration of function 'devlink_reload_disable'; did you mean 'devlink_is_reload_failed'? [-Werror=implicit-function-declaration]
   12762 |         devlink_reload_disable(bp->dl);
         |         ^~~~~~~~~~~~~~~~~~~~~~
         |         devlink_is_reload_failed
   drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_init_one':
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:13356:9: error: implicit declaration of function 'devlink_reload_enable'; did you mean 'devlink_is_reload_failed'? [-Werror=implicit-function-declaration]
   13356 |         devlink_reload_enable(bp->dl);
         |         ^~~~~~~~~~~~~~~~~~~~~
         |         devlink_is_reload_failed
   cc1: some warnings being treated as errors


vim +12762 drivers/net/ethernet/broadcom/bnxt/bnxt.c

 12756	
 12757	static void bnxt_remove_one(struct pci_dev *pdev)
 12758	{
 12759		struct net_device *dev = pci_get_drvdata(pdev);
 12760		struct bnxt *bp = netdev_priv(dev);
 12761	
 12762		devlink_reload_disable(bp->dl);
 12763		if (BNXT_PF(bp))
 12764			bnxt_sriov_disable(bp);
 12765	
 12766		if (BNXT_PF(bp))
 12767			devlink_port_type_clear(&bp->dl_port);
 12768	
 12769		bnxt_ptp_clear(bp);
 12770		pci_disable_pcie_error_reporting(pdev);
 12771		unregister_netdev(dev);
 12772		clear_bit(BNXT_STATE_IN_FW_RESET, &bp->state);
 12773		/* Flush any pending tasks */
 12774		cancel_work_sync(&bp->sp_task);
 12775		cancel_delayed_work_sync(&bp->fw_reset_task);
 12776		bp->sp_event = 0;
 12777	
 12778		bnxt_dl_fw_reporters_destroy(bp, true);
 12779		bnxt_dl_unregister(bp);
 12780		bnxt_shutdown_tc(bp);
 12781	
 12782		bnxt_clear_int_mode(bp);
 12783		bnxt_hwrm_func_drv_unrgtr(bp);
 12784		bnxt_free_hwrm_resources(bp);
 12785		bnxt_ethtool_free(bp);
 12786		bnxt_dcb_free(bp);
 12787		kfree(bp->edev);
 12788		bp->edev = NULL;
 12789		kfree(bp->ptp_cfg);
 12790		bp->ptp_cfg = NULL;
 12791		kfree(bp->fw_health);
 12792		bp->fw_health = NULL;
 12793		bnxt_cleanup_pci(bp);
 12794		bnxt_free_ctx_mem(bp);
 12795		kfree(bp->ctx);
 12796		bp->ctx = NULL;
 12797		kfree(bp->rss_indir_tbl);
 12798		bp->rss_indir_tbl = NULL;
 12799		bnxt_free_port_stats(bp);
 12800		free_netdev(dev);
 12801	}
 12802	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34016 bytes)