lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 27 Oct 2021 18:29:36 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, lgirdwood@...il.com, broonie@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: Fix unsigned comparison with less than zero

On Wed, 27 Oct 2021 16:59:51 +0800 Jiapeng Chong wrote:
> Fix the following coccicheck warning:
> 
> ./drivers/net/phy/at803x.c:493:5-10: WARNING: Unsigned expression
> compared with zero: value < 0.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Fixes: ea13c9ee855c ("drivers: net: phy: at803x: separate wol specific code to wol standard apis")

Please pay more attention.

This is not a correct fixes tag, take a look at the code, the
comparison was introduced in 7beecaf7d507 ("net: phy: at803x: improve
the WOL feature").

Do not fix spelling of the quoted commits. You replaced seperate
with separate and I had fun time trying to figure out why scripts
complain that the fixes tag is incorrect.

Fixed and applied to net-next.

Powered by blists - more mailing lists