netdev - Re: [PATCH bpf-next] libbpf: deprecate AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Oct 2021 15:56:00 +0200
From:   Magnus Karlsson <magnus.karlsson@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Björn Töpel <bjorn@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Ciara Loftus <ciara.loftus@...el.com>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next] libbpf: deprecate AF_XDP support

On Thu, Oct 28, 2021 at 3:45 PM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> Magnus Karlsson <magnus.karlsson@...il.com> writes:
>
> > From: Magnus Karlsson <magnus.karlsson@...el.com>
> >
> > Deprecate AF_XDP support in libbpf ([0]). This has been moved to
> > libxdp as it is a better fit for that library. The AF_XDP support only
> > uses the public libbpf functions and can therefore just use libbpf as
> > a library from libxdp. The libxdp APIs are exactly the same so it
> > should just be linking with libxdp instead of libbpf for the AF_XDP
> > functionality. If not, please submit a bug report. Linking with both
> > libraries is supported but make sure you link in the correct order so
> > that the new functions in libxdp are used instead of the deprecated
> > ones in libbpf.
> >
> > Libxdp can be found at https://github.com/xdp-project/xdp-tools.
> >
> > [0] https://github.com/libbpf/libbpf/issues/270
> >
> > Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
>
> Seems you typoed 'libxdp' as 'libdxp' in the deprecation messages :)

Ouch! I will spin a v2 for that, but I will wait for others to comment
first in case there are more things to fix. Thanks for spotting it!

> Other than that, though:
> Acked-by: Toke Høiland-Jørgensen <toke@...hat.com>
>