netdev - Re: [PATCH net v2] nfp: bpf: relax prog rejection for mtu check through max_pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211028075835.7121120c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 28 Oct 2021 07:58:35 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        oss-drivers@...igine.com, Yu Xiao <yu.xiao@...igine.com>,
        Yinjun Zhang <yinjun.zhang@...igine.com>,
        Niklas Soderlund <niklas.soderlund@...igine.com>
Subject: Re: [PATCH net v2] nfp: bpf: relax prog rejection for mtu check
 through max_pkt_offset

On Thu, 28 Oct 2021 12:00:36 +0200 Simon Horman wrote:
> From: Yu Xiao <yu.xiao@...igine.com>
> 
> MTU change is refused whenever the value of new MTU is bigger than
> the max packet bytes that fits in NFP Cluster Target Memory (CTM).
> However, an eBPF program doesn't always need to access the whole
> packet data.
> 
> The maximum direct packet access (DPA) offset has always been
> caculated by verifier and stored in the max_pkt_offset field of prog
> aux data.
> 
> Signed-off-by: Yu Xiao <yu.xiao@...igine.com>
> Reviewed-by: Yinjun Zhang <yinjun.zhang@...igine.com>
> Reviewed-by: Niklas Soderlund <niklas.soderlund@...igine.com>
> Signed-off-by: Simon Horman <simon.horman@...igine.com>

Looks fine, not sure why it's tagged for net but okay..