netdev - Re: [PATCH bpf-next v5 6/8] selftests/bpf: Add weak/typeless ksym test for light skeleton

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZm_R6JuV3pyN3qMJqPxZDZWJ_5kYTaX4BgbYB7Lk=t6w@mail.gmail.com>
Date:   Thu, 28 Oct 2021 11:06:43 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Kumar Kartikeya Dwivedi <memxor@...il.com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next v5 6/8] selftests/bpf: Add weak/typeless ksym
 test for light skeleton

On Wed, Oct 27, 2021 at 11:35 PM Kumar Kartikeya Dwivedi
<memxor@...il.com> wrote:
>
> Also, avoid using CO-RE features, as lskel doesn't support CO-RE, yet.
> Include both light and libbpf skeleton in same file to test both of them
> together.
>
> In c48e51c8b07a ("bpf: selftests: Add selftests for module kfunc support"),
> I added support for generating both lskel and libbpf skel for a BPF
> object, however the name parameter for bpftool caused collisions when
> included in same file together. This meant that every test needed a
> separate file for a libbpf/light skeleton separation instead of
> subtests.
>
> Change that by appending a "_lskel" suffix to the name for files using
> light skeleton, and convert all existing users.
>
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@...il.com>
> ---

I like the simplicity, thanks.

Acked-by: Andrii Nakryiko <andrii@...nel.org>

>  tools/testing/selftests/bpf/Makefile          |  4 +-
>  .../selftests/bpf/prog_tests/atomics.c        | 34 ++++++++--------
>  .../selftests/bpf/prog_tests/fentry_fexit.c   | 16 ++++----
>  .../selftests/bpf/prog_tests/fentry_test.c    | 14 +++----
>  .../selftests/bpf/prog_tests/fexit_sleep.c    | 12 +++---
>  .../selftests/bpf/prog_tests/fexit_test.c     | 14 +++----
>  .../selftests/bpf/prog_tests/kfunc_call.c     |  6 +--
>  .../selftests/bpf/prog_tests/ksyms_btf.c      | 35 +++++++++++++++-
>  .../selftests/bpf/prog_tests/ksyms_module.c   | 40 +++++++++++++++++--
>  .../bpf/prog_tests/ksyms_module_libbpf.c      | 28 -------------
>  .../selftests/bpf/prog_tests/ringbuf.c        | 12 +++---
>  .../selftests/bpf/prog_tests/trace_printk.c   | 14 +++----
>  .../selftests/bpf/prog_tests/trace_vprintk.c  | 12 +++---
>  .../selftests/bpf/prog_tests/verif_stats.c    |  6 +--
>  .../selftests/bpf/progs/test_ksyms_weak.c     |  2 +-
>  15 files changed, 142 insertions(+), 107 deletions(-)
>  delete mode 100644 tools/testing/selftests/bpf/prog_tests/ksyms_module_libbpf.c
>

[...]