netdev - Re: [PATCH net-next] batman-adv: Fix the wrong definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6da1057ad867699815cef87cb2a79057@linux.dev>
Date:   Thu, 28 Oct 2021 07:49:15 +0000
From:   yajun.deng@...ux.dev
To:     "Antonio Quartulli" <a@...table.cc>, mareklindner@...mailbox.ch,
        sw@...onwunderlich.de, sven@...fation.org
Cc:     b.a.t.m.a.n@...ts.open-mesh.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] batman-adv: Fix the wrong definition

October 28, 2021 3:35 PM, "Antonio Quartulli" <a@...table.cc> 写到:

> Hi,
> 
> On 28/10/2021 09:23, Yajun Deng wrote:
> 
>> There are three variables that are required at most,
>> no need to define four variables.
>> 
>> Fixes: 0fa4c30d710d ("batman-adv: Make sysfs support optional")
>> Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
> 
> NAK.
> 
> kobject_uevent_env() does not know how many items are stored in the
> array and thus requires it to be NULL terminated.
> 
> Please check the following for reference:
> 
> https://elixir.bootlin.com/linux/v5.15-rc6/source/lib/kobject_uevent.c#L548
> 
Oh, I didn't notice there.
> OTOH I guess we could still use '{}' for the initialization.
> 
> Regards,
> 
> --
> Antonio Quartulli