netdev - Re: [PATCH v1] can: etas_es58x: es58x_init_netdev: populate net_device::dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211029111829.crrwdjizlflzzhq2@pengutronix.de>
Date:   Fri, 29 Oct 2021 13:18:29 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc:     linux-can@...r.kernel.org, Lukas Magel <lukas.magel@...rypt.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] can: etas_es58x: es58x_init_netdev: populate
 net_device::dev_port

On 27.10.2021 03:05:53, Vincent Mailhol wrote:
> The field dev_port of struct net_device indicates the port number of a
> network device [1]. This patch populates this field.
> 
> This field can be helpful to distinguish between the two network
> interfaces of a dual channel device (i.e. ES581.4 or ES582.1). Indeed,
> at the moment, all the network interfaces of a same device share the
> same static udev attributes c.f. output of:
> 
> | udevadm info --attribute-walk /sys/class/net/canX
> 
> The dev_port attribute can then be used to write some udev rules to,
> for example, assign a permanent name to each network interface based
> on the serial/dev_port pair (which is convenient when you have a test
> bench with several CAN devices connected simultaneously and wish to
> keep consistent interface names upon reboot).
> 
> [1] https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-net
> 
> Suggested-by: Lukas Magel <lukas.magel@...rypt.com>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>

Applied to linux-can-next/testing.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)