netdev - Re: [RFC] should we allow BPF to transmit empty skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ead53f21-0649-1c5b-c157-6e1ec49d9458@gmail.com>
Date:   Fri, 29 Oct 2021 08:48:37 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [RFC] should we allow BPF to transmit empty skbs



On 10/29/21 8:41 AM, Alexei Starovoitov wrote:
> On Fri, Oct 29, 2021 at 8:39 AM Daniel Borkmann <daniel@...earbox.net> wrote:
>>
>> On 10/29/21 5:22 PM, Eric Dumazet wrote:
>>> Some layers in tx path do not expect skb being empty (skb->len == 0)
>>>
>>> syzbot reported a crash [1] in fq_codel.
>>>
>>> But I expect many drivers would also crash later.
>>>
>>> Sure the immediate fq_codel crash could be 'fixed', but I would rather
>>> add some sanity checks in net/core/filter.c
>>
>> Makes sense, we shouldn't have to add this to fq_codel fast path, but rather
>> a sanity check for bpf_clone_redirect().
>>
>> I wonder if it's only related to bpf_prog_test_run() infra or if it could also
>> have been generated via stack?
> 
> probably bpf_prog_test_run_skb only.
> I would only add size !=0 check there.
> 

We have a C repro, I will release the syzbot bug so that it can be shared with you.

Thanks.