netdev - Re: [PATCH net-next 1/3] net: sgi-xp: use eth_hw_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YXwZzBzmIFBMS0gO@swahl-home.5wahls.com>
Date:   Fri, 29 Oct 2021 10:57:00 -0500
From:   Steve Wahl <steve.wahl@....com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, robinmholt@...il.com,
        steve.wahl@....com, mike.travis@....com, arnd@...db.de,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH net-next 1/3] net: sgi-xp: use eth_hw_addr_set()

Reveiwed-by: Steve Wahl <steve.wahl@....com>

On Thu, Oct 28, 2021 at 07:47:05PM -0700, Jakub Kicinski wrote:
> Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> of VLANs...") introduced a rbtree for faster Ethernet address look
> up. To maintain netdev->dev_addr in this tree we need to make all
> the writes to it go through appropriate helpers.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: robinmholt@...il.com
> CC: steve.wahl@....com
> CC: mike.travis@....com
> CC: arnd@...db.de
> CC: gregkh@...uxfoundation.org
> ---
>  drivers/misc/sgi-xp/xpnet.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/sgi-xp/xpnet.c b/drivers/misc/sgi-xp/xpnet.c
> index 2508f83bdc3f..dab7b92db790 100644
> --- a/drivers/misc/sgi-xp/xpnet.c
> +++ b/drivers/misc/sgi-xp/xpnet.c
> @@ -514,6 +514,7 @@ static const struct net_device_ops xpnet_netdev_ops = {
>  static int __init
>  xpnet_init(void)
>  {
> +	u8 addr[ETH_ALEN];
>  	int result;
>  
>  	if (!is_uv_system())
> @@ -545,15 +546,17 @@ xpnet_init(void)
>  	xpnet_device->min_mtu = XPNET_MIN_MTU;
>  	xpnet_device->max_mtu = XPNET_MAX_MTU;
>  
> +	memset(addr, 0, sizeof(addr));
>  	/*
>  	 * Multicast assumes the LSB of the first octet is set for multicast
>  	 * MAC addresses.  We chose the first octet of the MAC to be unlikely
>  	 * to collide with any vendor's officially issued MAC.
>  	 */
> -	xpnet_device->dev_addr[0] = 0x02;     /* locally administered, no OUI */
> +	addr[0] = 0x02;     /* locally administered, no OUI */
>  
> -	xpnet_device->dev_addr[XPNET_PARTID_OCTET + 1] = xp_partition_id;
> -	xpnet_device->dev_addr[XPNET_PARTID_OCTET + 0] = (xp_partition_id >> 8);
> +	addr[XPNET_PARTID_OCTET + 1] = xp_partition_id;
> +	addr[XPNET_PARTID_OCTET + 0] = (xp_partition_id >> 8);
> +	eth_hw_addr_set(xpnet_device, addr);
>  
>  	/*
>  	 * ether_setup() sets this to a multicast device.  We are
> -- 
> 2.31.1
> 

-- 
Steve Wahl, Hewlett Packard Enterprise